Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export obsolete products - draft #8397

Merged
merged 3 commits into from
May 11, 2023
Merged

fix: export obsolete products - draft #8397

merged 3 commits into from
May 11, 2023

Conversation

stephanegigandet
Copy link
Contributor

Show the number of products that are not exported in both products and products_obsolete collections, and export both.

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 4, 2023 17:40
@github-actions github-actions bot added Display export 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels May 4, 2023
alexgarel
alexgarel approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work !

lib/ProductOpener/Export.pm Show resolved Hide resolved
@alexgarel alexgarel enabled auto-merge (squash) May 11, 2023 12:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel merged commit efa8c72 into main May 11, 2023
@alexgarel alexgarel deleted the obsolete2 branch May 11, 2023 12:41
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 11, 2023
Merged
@teolemon teolemon mentioned this pull request Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Display export 🗄 Obsolete products 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @alexgarel @teolemon